Attention is currently required from: Michał Żygowski, Michał Kopeć, Stefan Reinauer, Maximilian Brune.
Kacper Stojek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66825 )
Change subject: util/inteltool: Add support for Alderlake P in inteltool
......................................................................
Patch Set 10:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66825/comment/a5cae2c7_274c1227
PS8, Line 8:
Could you add the source of your information? In your case for example: 626817 (Intel Document ID)
Listed the document ID's.
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/66825/comment/d7918b17_cd8ae896
PS8, Line 364: #define PCI_DEVICE_ID_INTEL_CORE_ADL_P_ID_1 0x4629
indentation seems to need a fix.
Yes, it looked fine in my editor, didn't notice it was wrong here, now it should be aligned correctly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66825
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ba4ef7eee33d4dd762a05dd755de5e4d2e566dd
Gerrit-Change-Number: 66825
Gerrit-PatchSet: 10
Gerrit-Owner: Kacper Stojek
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Mon, 12 Sep 2022 10:29:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment