[S] Change in coreboot[main]: drivers/intel/fsp2_0: Add Kconfig option to control MBP HOB creation

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84217?usp=email )

Change subject: drivers/intel/fsp2_0: Add Kconfig option to control MBP HOB creation
......................................................................

drivers/intel/fsp2_0: Add Kconfig option to control MBP HOB creation

This patch adds a new Kconfig option `FSP_PUBLISH_MBP_HOB` to
control the creation of the ME_BIOS_PAYLOAD_HOB (MBP HOB) by FSP.

Disabling this option can improve boot time on platforms that
do not utilize the MBP HOB, such as ChromeOS devices.

The option is disabled by default on ChromeOS and enabled
by default on other platforms.

On ADL-P based platforms, this option is forced to be enabled
as ADL-P FSP relies on MBP HOB for ChipsetInit version for
ChipsetInit sync.

Removed SoC specific implementation of `FSP_PUBLISH_MBP_HOB` config
from MTL and TGL config file.

TEST=Tested on ADL-P and ADL-N platforms. Verified that MBP HOB is
created when `FSP_PUBLISH_MBP_HOB` is enabled and not created when
it is disabled.
Also verified that the system boots successfully in both cases.

Change-Id: I21da00259c0b9bcca6f545291a6259e9cce8d900
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84217
Tested-by: build bot (Jenkins) 
Reviewed-by: Eric Lai 
---
M src/drivers/intel/fsp2_0/Kconfig
M src/soc/intel/alderlake/Kconfig
M src/soc/intel/meteorlake/Kconfig
M src/soc/intel/pantherlake/Kconfig
4 files changed, 16 insertions(+), 26 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Eric Lai: Looks good to me, approved

diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig
index 2ad3209..bbf0710 100644
--- a/src/drivers/intel/fsp2_0/Kconfig
+++ b/src/drivers/intel/fsp2_0/Kconfig
@@ -522,4 +522,15 @@
      reported with Alder Lake and Raptor Lake FSP where MultiPhaseSiInit API is unable
      to return any ERROR status.

+config FSP_PUBLISH_MBP_HOB
+	bool
+	default n if CHROMEOS
+	default y
+	help
+	  This is to control creation of ME_BIOS_PAYLOAD_HOB (MBP HOB) by FSP.
+	  Disabling it for the platforms, which do not use MBP HOB, can improve the boot time.
+
+	  ChromeOS devices typically do not require the MBP information, hence it is disabled
+	  by default on ChromeOS.
+
 endif
diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig
index f7c585a..c1cc993 100644
--- a/src/soc/intel/alderlake/Kconfig
+++ b/src/soc/intel/alderlake/Kconfig
@@ -511,18 +511,13 @@
 config INTEL_GMA_BCLM_WIDTH
    default 32

+# Note: It cannot be disabled for ADL-P based platforms because ADL-P FSP relies on
+# MBP HOB for ChipsetInit version for ChipsetInit sync. As ChipsetInit sync doesn't
+# occur if no MBP HOB, so it results S0ix issue. This limitation is addressed in the
+# later platforms so creation of MBP HOB can be skipped for ADL-N based platforms.
 config FSP_PUBLISH_MBP_HOB
    bool
-	default n if CHROMEOS && (SOC_INTEL_ALDERLAKE_PCH_N)
-	default y
-	help
-	  This is to control creation of ME_BIOS_PAYLOAD_HOB (MBP HOB) by FSP.
-	  Disabling it for the platforms, which do not use MBP HOB, can improve the boot time.
-
-	  Note: It cannot be disabled for ADL-P based platforms because ADL-P FSP relies on
-	  MBP HOB for ChipsetInit version for ChipsetInit sync. As ChipsetInit sync doesn't
-	  occur if no MBP HOB, so it results S0ix issue. This limitation is addressed in the
-	  later platforms so creation of MBP HOB can be skipped for ADL-N based platforms.
+	default y if !SOC_INTEL_ALDERLAKE_PCH_N

config INCLUDE_HSPHY_IN_FMAP
    bool "Include PCIe 5.0 HSPHY firmware in flash"
diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig
index 79ef3e8..753af7c 100644
--- a/src/soc/intel/meteorlake/Kconfig
+++ b/src/soc/intel/meteorlake/Kconfig
@@ -380,14 +380,6 @@
    hex
    default 0x800000

-config FSP_PUBLISH_MBP_HOB
-	bool
-	default n if CHROMEOS
-	default y
-	help
-	  This is to control creation of ME_BIOS_PAYLOAD_HOB (MBP HOB) by FSP.
-	  Disabling it for the platforms, which do not use MBP HOB, can improve the boot time.
-
 config BUILDING_WITH_DEBUG_FSP
    bool "Debug FSP is used for the build"
    default n
diff --git a/src/soc/intel/pantherlake/Kconfig b/src/soc/intel/pantherlake/Kconfig
index 9a5fc61..e5f7c92 100644
--- a/src/soc/intel/pantherlake/Kconfig
+++ b/src/soc/intel/pantherlake/Kconfig
@@ -248,12 +248,4 @@
    help
      Set this option if debug build of FSP is used.

-config FSP_PUBLISH_MBP_HOB
-	bool
-	default n if CHROMEOS
-	default y
-	help
-	  This is to control creation of ME_BIOS_PAYLOAD_HOB (MBP HOB) by FSP.
-	  Disabling it for the platforms, which do not use MBP HOB, can improve the boot time.
-
 endif