Change in coreboot[master]: util/lint/Kconfig_lint: Update Naked BOOL reference to error
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43826 )
Change subject: util/lint/Kconfig_lint: Update Naked BOOL reference to error ......................................................................
util/lint/Kconfig_lint: Update Naked BOOL reference to error
The lint-stable makefile target only watches for errors in the Kconfig file, so has not protected additional "Naked" references to BOOL type Kconfig symbols from entering the tree. Update it to an error so that they can't continue coming into the codebase.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Icce2a9a627c4fbcaa220df18474cb8bfea8b2a8c --- M util/lint/kconfig_lint 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43826/1
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 8ee6416..2341976 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -332,7 +332,7 @@ $line = $1 . $3; if ( exists $symbols{$symbol} ) { if ( $symbols{$symbol}{type} eq "bool" ) { - show_warning( "Naked reference to CONFIG_$symbol used at $file:$lineno." + show_error( "Naked reference to CONFIG_$symbol used at $file:$lineno." . " A 'bool' Kconfig should always be accessed through CONFIG($symbol)." ); } } else {
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43826 )
Change subject: util/lint/Kconfig_lint: Update Naked BOOL reference to error ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43826 )
Change subject: util/lint/Kconfig_lint: Update Naked BOOL reference to error ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43826 )
Change subject: util/lint/Kconfig_lint: Update Naked BOOL reference to error ......................................................................
util/lint/Kconfig_lint: Update Naked BOOL reference to error
The lint-stable makefile target only watches for errors in the Kconfig file, so has not protected additional "Naked" references to BOOL type Kconfig symbols from entering the tree. Update it to an error so that they can't continue coming into the codebase.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Icce2a9a627c4fbcaa220df18474cb8bfea8b2a8c Reviewed-on: https://review.coreboot.org/c/coreboot/+/43826 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/lint/kconfig_lint 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 8ee6416..2341976 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -332,7 +332,7 @@ $line = $1 . $3; if ( exists $symbols{$symbol} ) { if ( $symbols{$symbol}{type} eq "bool" ) { - show_warning( "Naked reference to CONFIG_$symbol used at $file:$lineno." + show_error( "Naked reference to CONFIG_$symbol used at $file:$lineno." . " A 'bool' Kconfig should always be accessed through CONFIG($symbol)." ); } } else {
-
Angel Pons (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)