Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45385 )
Change subject: nb/intel/pineview/iomap.h: Rename to memmap.h ......................................................................
nb/intel/pineview/iomap.h: Rename to memmap.h
It primarily contains definitions for MMIO windows.
Change-Id: I8cd639c8c7d400a5bfd73735113dd27dd6f948e6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/pineview/acpi/pineview.asl R src/northbridge/intel/pineview/memmap.h M src/northbridge/intel/pineview/pineview.h 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45385/1
diff --git a/src/northbridge/intel/pineview/acpi/pineview.asl b/src/northbridge/intel/pineview/acpi/pineview.asl index 3579a26..9515c31 100644 --- a/src/northbridge/intel/pineview/acpi/pineview.asl +++ b/src/northbridge/intel/pineview/acpi/pineview.asl @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include "hostbridge.asl" -#include "../iomap.h" +#include "../memmap.h" #include <southbridge/intel/common/rcba.h>
/* PCI Device Resource Consumption */ diff --git a/src/northbridge/intel/pineview/iomap.h b/src/northbridge/intel/pineview/memmap.h similarity index 73% rename from src/northbridge/intel/pineview/iomap.h rename to src/northbridge/intel/pineview/memmap.h index 4560da0..50ede0b 100644 --- a/src/northbridge/intel/pineview/iomap.h +++ b/src/northbridge/intel/pineview/memmap.h @@ -1,11 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#ifndef PINEVIEW_IOMAP_H -#define PINEVIEW_IOMAP_H +#ifndef PINEVIEW_MEMMAP_H +#define PINEVIEW_MEMMAP_H
#define DEFAULT_MCHBAR 0xfed14000 /* 16 KB */ #define DEFAULT_DMIBAR 0xfed18000 /* 4 KB */ #define DEFAULT_EPBAR 0xfed19000 /* 4 KB */ #define DEFAULT_PMIOBAR 0x00000400
-#endif /* PINEVIEW_IOMAP_H */ +#endif /* PINEVIEW_MEMMAP_H */ diff --git a/src/northbridge/intel/pineview/pineview.h b/src/northbridge/intel/pineview/pineview.h index 47257dd..19b9584 100644 --- a/src/northbridge/intel/pineview/pineview.h +++ b/src/northbridge/intel/pineview/pineview.h @@ -3,7 +3,7 @@ #ifndef NORTHBRIDGE_INTEL_PINEVIEW_H #define NORTHBRIDGE_INTEL_PINEVIEW_H
-#include <northbridge/intel/pineview/iomap.h> +#include <northbridge/intel/pineview/memmap.h> #include <southbridge/intel/i82801gx/i82801gx.h>
#define BOOT_PATH_NORMAL 0
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45385 )
Change subject: nb/intel/pineview/iomap.h: Rename to memmap.h ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Damien Zammit, Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45385
to look at the new patch set (#3).
Change subject: nb/intel/pineview/iomap.h: Rename to memmap.h ......................................................................
nb/intel/pineview/iomap.h: Rename to memmap.h
It primarily contains definitions for MMIO windows.
Change-Id: I8cd639c8c7d400a5bfd73735113dd27dd6f948e6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/pineview/acpi/pineview.asl R src/northbridge/intel/pineview/memmap.h M src/northbridge/intel/pineview/pineview.h 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45385/3
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45385 )
Change subject: nb/intel/pineview/iomap.h: Rename to memmap.h ......................................................................
nb/intel/pineview/iomap.h: Rename to memmap.h
It primarily contains definitions for MMIO windows.
Change-Id: I8cd639c8c7d400a5bfd73735113dd27dd6f948e6 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45385 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/pineview/acpi/pineview.asl R src/northbridge/intel/pineview/memmap.h M src/northbridge/intel/pineview/pineview.h 3 files changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/pineview/acpi/pineview.asl b/src/northbridge/intel/pineview/acpi/pineview.asl index 3579a26..9515c31 100644 --- a/src/northbridge/intel/pineview/acpi/pineview.asl +++ b/src/northbridge/intel/pineview/acpi/pineview.asl @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include "hostbridge.asl" -#include "../iomap.h" +#include "../memmap.h" #include <southbridge/intel/common/rcba.h>
/* PCI Device Resource Consumption */ diff --git a/src/northbridge/intel/pineview/iomap.h b/src/northbridge/intel/pineview/memmap.h similarity index 73% rename from src/northbridge/intel/pineview/iomap.h rename to src/northbridge/intel/pineview/memmap.h index 4560da0..50ede0b 100644 --- a/src/northbridge/intel/pineview/iomap.h +++ b/src/northbridge/intel/pineview/memmap.h @@ -1,11 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#ifndef PINEVIEW_IOMAP_H -#define PINEVIEW_IOMAP_H +#ifndef PINEVIEW_MEMMAP_H +#define PINEVIEW_MEMMAP_H
#define DEFAULT_MCHBAR 0xfed14000 /* 16 KB */ #define DEFAULT_DMIBAR 0xfed18000 /* 4 KB */ #define DEFAULT_EPBAR 0xfed19000 /* 4 KB */ #define DEFAULT_PMIOBAR 0x00000400
-#endif /* PINEVIEW_IOMAP_H */ +#endif /* PINEVIEW_MEMMAP_H */ diff --git a/src/northbridge/intel/pineview/pineview.h b/src/northbridge/intel/pineview/pineview.h index 47257dd..19b9584 100644 --- a/src/northbridge/intel/pineview/pineview.h +++ b/src/northbridge/intel/pineview/pineview.h @@ -3,7 +3,7 @@ #ifndef NORTHBRIDGE_INTEL_PINEVIEW_H #define NORTHBRIDGE_INTEL_PINEVIEW_H
-#include <northbridge/intel/pineview/iomap.h> +#include <northbridge/intel/pineview/memmap.h> #include <southbridge/intel/i82801gx/i82801gx.h>
#define BOOT_PATH_NORMAL 0
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45385 )
Change subject: nb/intel/pineview/iomap.h: Rename to memmap.h ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19806 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19805 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19804 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19803 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19802 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19810 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19809 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19808 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19807
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Arthur Heymans (Code Review)