Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
device/Kconfig: fix circular dependency for RUN_FSP_GOP
Change Graphics Init default for RUN_FSP_GOP to depend on INTEL_GMA_HAVE_VBT rather than INTEL_GMA_ADD_VBT, since RUN_FSP_GOP selects INTEL_GMA_ADD_VBT for several Intel SoC's.
Test: create default config for gogle/cyan, RUN_FSP_GOP still default display init selection but no more circular dependency warning from config.
Change-Id: I8b978d9938c3d0024d4dd40000b988430664cee7 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/device/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/39910/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index 64f1693..951062c 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -69,7 +69,7 @@ default VGA_ROM_RUN if VGA_BIOS default MAINBOARD_DO_NATIVE_VGA_INIT default MAINBOARD_USE_LIBGFXINIT - default RUN_FSP_GOP if INTEL_GMA_ADD_VBT + default RUN_FSP_GOP if INTEL_GMA_HAVE_VBT
config MAINBOARD_DO_NATIVE_VGA_INIT bool "Use native graphics init"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
Patch Set 1: Code-Review+1
Prasun Gera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
Patch Set 1:
Fixed the error for me on T530. Build test passed.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
Patch Set 1:
Patch Set 1:
Fixed the error for me on T530. Build test passed.
Thanks! Now, let's wait for Mr. Jenkins
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
Patch Set 1: Code-Review+2
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
Patch Set 2: Code-Review+1
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
Patch Set 2: Code-Review+2
This fixes the error I currently see on the mc_aplx boards.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39910 )
Change subject: device/Kconfig: fix circular dependency for RUN_FSP_GOP ......................................................................
device/Kconfig: fix circular dependency for RUN_FSP_GOP
Change Graphics Init default for RUN_FSP_GOP to depend on INTEL_GMA_HAVE_VBT rather than INTEL_GMA_ADD_VBT, since RUN_FSP_GOP selects INTEL_GMA_ADD_VBT for several Intel SoC's.
Test: create default config for gogle/cyan, RUN_FSP_GOP still default display init selection but no more circular dependency warning from config.
Change-Id: I8b978d9938c3d0024d4dd40000b988430664cee7 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39910 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Benjamin Doron benjamin.doron00@gmail.com Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/device/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved Angel Pons: Looks good to me, approved Benjamin Doron: Looks good to me, but someone else must approve
diff --git a/src/device/Kconfig b/src/device/Kconfig index 64f1693..951062c 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -69,7 +69,7 @@ default VGA_ROM_RUN if VGA_BIOS default MAINBOARD_DO_NATIVE_VGA_INIT default MAINBOARD_USE_LIBGFXINIT - default RUN_FSP_GOP if INTEL_GMA_ADD_VBT + default RUN_FSP_GOP if INTEL_GMA_HAVE_VBT
config MAINBOARD_DO_NATIVE_VGA_INIT bool "Use native graphics init"
-
Angel Pons (Code Review) -
Benjamin Doron (Code Review)
-
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Prasun Gera (Code Review)
-
Werner Zeh (Code Review)