Attention is currently required from: Tarun Tuli, Kapil Porwal, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69680 )
Change subject: soc/intel/meteorlake: Skip setting D0I3 bit for HECI devices ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69680/comment/d827e5ed_9d44f813 PS1, Line 9: This patch skips setting D0I3 bit for all HECI devices by FSP.
@Sridhar, this is the backporting of the ADL CL, please take a look into the original CL for the reasoning.
May I know concern sharing the reason here as well?
what is the point of sharing the reason when you have provided the original CL and clearly telling `it's a backport` ?
TL;DR: This is to ensure FSP can skip setting D0i3 bit for CSE and coreboot is able to sent EOP and put the HECI devices into the D0i3.
Please add the message to commit message. Thanks