Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61794?usp=email )
Change subject: cpu/x86/lapic: Always have LAPIC enabled ......................................................................
cpu/x86/lapic: Always have LAPIC enabled
LAPIC has been available since P54C released 1993.
Change-Id: Id564a3007ea7a3d9fb81005a05399a18c4cf7289 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/61794 Reviewed-by: coreboot org coreboot.org@gmail.com Reviewed-by: Elyes Haouas ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/x86/lapic/lapic.c M src/include/cpu/x86/lapic.h 2 files changed, 0 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved coreboot org: Looks good to me, approved
diff --git a/src/cpu/x86/lapic/lapic.c b/src/cpu/x86/lapic/lapic.c index 8e0449a..6afd6c56 100644 --- a/src/cpu/x86/lapic/lapic.c +++ b/src/cpu/x86/lapic/lapic.c @@ -64,14 +64,6 @@ enable_lapic_mode(try_set_x2apic); }
-void disable_lapic(void) -{ - msr_t msr; - msr = rdmsr(LAPIC_BASE_MSR); - msr.lo &= ~(LAPIC_BASE_MSR_ENABLE | LAPIC_BASE_MSR_X2APIC_MODE); - wrmsr(LAPIC_BASE_MSR, msr); -} - uintptr_t cpu_get_lapic_addr(void) { return LAPIC_DEFAULT_BASE; diff --git a/src/include/cpu/x86/lapic.h b/src/include/cpu/x86/lapic.h index 87cf3c7..0e1384f 100644 --- a/src/include/cpu/x86/lapic.h +++ b/src/include/cpu/x86/lapic.h @@ -181,7 +181,6 @@
void enable_lapic(void); void enable_lapic_mode(bool try_set_x2apic); -void disable_lapic(void); void setup_lapic_interrupts(void);
static inline unsigned int early_lapicid(void)