Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45412 )
Change subject: soc/intel/common/block/sgx: make PRMRR size setting depend on SGX
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45412/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/45412/3/src/soc/intel/common/block/...
PS3, Line 349: if (!CONFIG(SOC_INTEL_COMMON_BLOCK_SGX) || !CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_ENABLE))
Nit, the latter should suffice.
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45412
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I551942fd9cb8e7123d00dbd752abffe24788148c
Gerrit-Change-Number: 45412
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 19 Sep 2020 13:26:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment