[XL] Change in coreboot[main]: soc/meidatek/mt8196: Add SPM loader

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Ccong Chen, Hung-Te Lin, Wenzhen Yu, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email )

Change subject: soc/meidatek/mt8196: Add SPM loader
......................................................................

Patch Set 3:

(13 comments)

File src/soc/mediatek/common/Kconfig:

https://review.coreboot.org/c/coreboot/+/85599/comment/b11902c1_da2c1309?usp... :
PS3, Line 122: version2. This version of the chip design
             : 	  has been simplified
`version 2, where the chip design is simplified compared to version 1.`

File src/soc/mediatek/mt8196/include/soc/spm.h:

https://review.coreboot.org/c/coreboot/+/85599/comment/cbd2eafe_21810445?usp... :
PS3, Line 636: 	u32 reserved1;
Revert these unrelated changes.

https://review.coreboot.org/c/coreboot/+/85599/comment/c52974e5_507c7a92?usp... :
PS3, Line 690: 	u32 reserved12[3];
Revert these unrelated changes.

https://review.coreboot.org/c/coreboot/+/85599/comment/f291cbc6_5a575893?usp... :
PS3, Line 717: reserved16
Why is this changed to "reserved"?

https://review.coreboot.org/c/coreboot/+/85599/comment/2f0926db_5d9b2282?usp... :
PS3, Line 1117: u32 pcm_apwdt_latch_27;
              : 	u32 pcm_apwdt_latch_28;
              : 	u32 pcm_apwdt_latch_29;
              : 	u32 pcm_apwdt_latch_30;
              : 	u32 pcm_apwdt_latch_31;
              : 	u32 pcm_apwdt_latch_32;
              : 	u32 pcm_apwdt_latch_33;
              : 	u32 pcm_apwdt_latch_34;
              : 	u32 pcm_apwdt_latch_35;
              : 	u32 pcm_apwdt_latch_36;
              : 	u32 pcm_apwdt_latch_37;
              : 	u32 pcm_apwdt_latch_38;
`u32 pcm_apwdt_latch_27[12]`

File src/soc/mediatek/mt8196/include/soc/spm.h:

https://review.coreboot.org/c/coreboot/+/85599/comment/80399c09_edd06ee3?usp... :
PS1, Line 13: 0x1c001108
> Done

I meant defining a structure similar to `mtk_vlpcksys_regs`.

File src/soc/mediatek/mt8196/spm.c:

https://review.coreboot.org/c/coreboot/+/85599/comment/78c8fccd_97e0de48?usp... :
PS1, Line 738: status
> Done

Not done.

File src/soc/mediatek/mt8196/spm.c:

https://review.coreboot.org/c/coreboot/+/85599/comment/e0ea12da_85bd8e40?usp... :
PS3, Line 742: 				SPM_ACK_CHK_3_CON_EN);
align

https://review.coreboot.org/c/coreboot/+/85599/comment/9fddf3d0_3222d4f2?usp... :
PS3, Line 744: 
Remove blank line

https://review.coreboot.org/c/coreboot/+/85599/comment/48046918_eccbd82f?usp... :
PS3, Line 753: 				SPM_ACK_CHK_3_CON_HW_MODE_TRIG | SPM_ACK_CHK_3_CON_CLR_ALL,
align

https://review.coreboot.org/c/coreboot/+/85599/comment/e26379d1_322c256d?usp... :
PS3, Line 816: spm_resource_ack_con
`spm_resource_ack_con[0]`

https://review.coreboot.org/c/coreboot/+/85599/comment/44540573_40b085f5?usp... :
PS3, Line 827: spm_resource_ack_con
`spm_resource_ack_con[0]`

https://review.coreboot.org/c/coreboot/+/85599/comment/c560b928_34bafa52?usp... :
PS3, Line 835: (
remove