Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36087 )
Change subject: soc/intel/tigerlake: Do initial SoC commit
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36087/8/src/soc/intel/tigerlake/gra...
File src/soc/intel/tigerlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/36087/8/src/soc/intel/tigerlake/gra...
PS8, Line 73: * GFX PEIM module inside FSP binary is taking care of graphics
should depend on RUN_FSP_GOP
isn;t below code does the same check ?
if (CONFIG(INTEL_GMA_ADD_VBT))
return;
https://review.coreboot.org/c/coreboot/+/36087/8/src/soc/intel/tigerlake/gra...
PS8, Line 78: * In case of non-FSP solution, SoC need to select VGA_ROM_RUN
Well, there is no VBIOS for Tiger Lake, is there? Was there one for […]
well. we do have some VBIOS as well although we preferred to use GOP
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36087
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id95e2fa9b7a7c6b3b9233d2c438b25a6c4904bbb
Gerrit-Change-Number: 36087
Gerrit-PatchSet: 8
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 29 Oct 2019 11:46:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment