Change in coreboot[master]: acpi: Convert ACPI_DEVICE_SLEEP_* values to an enum - coreboot-gerrit

29 Nov 2021


      Attention is currently required from: Lance Zhao, Subrata Banik, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59634 )
Change subject: acpi: Convert ACPI_DEVICE_SLEEP_* values to an enum
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
oh, didn't think of using those defines in the asl code. […]
It's possible? Usually it's used for e.g. _S0W, which is typically generated by acpigen. We haven't seen a use-case yet for having them in the ASL files (and wouldn't we rather keep more things out of them anyway? 😊)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b8586b46823b5da3614a0b2a2f2f16802e96962
Gerrit-Change-Number: 59634
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 29 Nov 2021 16:39:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment