Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83989?usp=email )
Change subject: soc/mediatek: Move SNFC pad_func into MediaTek common directory
......................................................................
Patch Set 4: -Code-Review
(1 comment)
File src/soc/mediatek/common/include/soc/flash_controller_common.h:
https://review.coreboot.org/c/coreboot/+/83989/comment/aecae552_e3ae454e?usp... :
PS4, Line 80: struct pad_func {
: gpio_t gpio;
: u8 func;
: enum pull_select select;
: };
Redefinition in MT8195.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83989?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I145233ef887a38251e8fc129b8357f236c5f7a2b
Gerrit-Change-Number: 83989
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 22 Aug 2024 12:55:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes