Attention is currently required from: Nico Huber, Jan Tatje.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56071 )
Change subject: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
FSP does this: […]
SkipExtGfxScan=0 let's FSP scan for PCIe graphics. If found, it sets PrimaryDisplay=PCI. Then it scans for PEG. If found, PrimaryDisplay becomes PEG, but only of PCI was not found... so, PCI would even take precedence over PEG.
With SkipExtGfxScan=1 the difference between PEG and PCI is gone, so you're right, that we just must not set Auto or IGD.
=> we should keep SkipExtGfxScan=1 (or maybe even drop the dt option and set it statically?) and set PrimaryDisplay=PCI/PEG
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41249112c65927b61ca5f791f8eb8c3f3d204fce
Gerrit-Change-Number: 56071
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Tatje
jan@jnt.io
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jan Tatje
jan@jnt.io
Gerrit-Comment-Date: Fri, 09 Jul 2021 19:13:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jan Tatje
jan@jnt.io
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment