Attention is currently required from: Eric Lai, Jon Murphy, Karthik Ramasubramanian, Paul Menzel, Tim Van Patten.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75629?usp=email )
Change subject: mb/google/myst: Enable fingerprint on UART
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/75629/comment/125d35ae_340ffb36 :
PS3, Line 71: PAD_GPO(GPIO_40, LOW),
Micheal said we should keep it low durning boot. You can check the chat.
If that actually adds a delay to the boot sequence, it's working directly against our boot time optimization. I think we need to design a method of switching GPIOs at appropriate times instead of using delays.
I don't think this question should hold up this patch though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75629?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09819037b80e55edeb56faef9e27fe0753748efc
Gerrit-Change-Number: 75629
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 06 Jun 2023 19:55:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment