Attention is currently required from: Angel Pons, Julius Werner.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55038 )
Change subject: src/lib/fmap.c: use le*toh() functions where needed
......................................................................
Patch Set 1:
(1 comment)
File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/55038/comment/8b92174b_4f9ead2d
PS1, Line 239: ar->offset, ar->size, area->name);
I suppose accesses like these need to be updated, too?
This function is not called anywhere in the code currently, and I assumed that the data passed to it would already be in host endianness.
(sorry for the delay, I keep forgetting to hit reply button)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55038
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8784ac29101531db757249496315f43e4008de4f
Gerrit-Change-Number: 55038
Gerrit-PatchSet: 1
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 12 Jul 2021 17:08:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment