Attention is currently required from: SH Kim, Shou-Chieh Hsu, Tarun Tuli.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76882?usp=email )
Change subject: mb/google/nissa/var/pirrha: Add GPIO table ......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/brya/variants/pirrha/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76882/comment/476697a9_75dda6be : PS2, Line 4: romstage-y += gpio.c This is not necessary as you don't override gpio in romstage
File src/mainboard/google/brya/variants/pirrha/gpio.c:
https://review.coreboot.org/c/coreboot/+/76882/comment/cd719346_09eec06d : PS2, Line 99: static const struct pad_config romstage_gpio_table[] = { : }; Probably you don't need this table as it's empty
https://review.coreboot.org/c/coreboot/+/76882/comment/f8abfb9b_6612691c : PS2, Line 115: const struct pad_config *variant_romstage_gpio_table(size_t *num) : { : *num = ARRAY_SIZE(romstage_gpio_table); : return romstage_gpio_table; : } same as above.