Change in coreboot[master]: util/superiotool: build fix for FreeBSD

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Idwer Vollering (Code Review)

16 Dec 2019 16 Dec '19

6:52 a.m.

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37768 )

Change subject: util/superiotool: build fix for FreeBSD ......................................................................

util/superiotool: build fix for FreeBSD

Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/superiotool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/37768/1

diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile index 2bc88ab..dc47aed 100644 --- a/util/superiotool/Makefile +++ b/util/superiotool/Makefile @@ -60,7 +60,7 @@ endif endif

-all: pciutils $(PROGRAM) +all: $(PROGRAM)

superiotool.o: *.c superiotool.h

Attachments:

attachment.htm (text/html — 2.2 KB)

Show replies by date

Paul Menzel (Code Review)

16 Dec 16 Dec

6:56 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37768 )

Change subject: util/superiotool: build fix for FreeBSD ......................................................................

Patch Set 1:

(2 comments)

Thank you for the fix.

https://review.coreboot.org/c/coreboot/+/37768/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37768/1//COMMIT_MSG@7 PS1, Line 7: util/superiotool: build fix for FreeBSD Please use a statement:

...

Fix build for FreeBSD

https://review.coreboot.org/c/coreboot/+/37768/1//COMMIT_MSG@8 PS1, Line 8: Please elaborate on the error that is fixed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Gerrit-Change-Number: 37768 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 16 Dec 2019 14:56:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Idwer Vollering (Code Review)

4:02 p.m.

New subject: Change in coreboot[master]: util/superiotool: alter Makefile to build the binary on FreeBSD

Hello Felix Held, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37768

to look at the new patch set (#2).

Change subject: util/superiotool: alter Makefile to build the binary on FreeBSD ......................................................................

util/superiotool: alter Makefile to build the binary on FreeBSD

With the 'pciutils' target inbetween, the PCI library (-lpci) can not be found even though it is installed.

Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/superiotool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/37768/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Gerrit-Change-Number: 37768 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Held (Code Review)

18 Dec 18 Dec

2:04 p.m.

New subject: Change in coreboot[master]: util/superiotool: alter Makefile to build the binary on FreeBSD

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37768 )

Change subject: util/superiotool: alter Makefile to build the binary on FreeBSD ......................................................................

Patch Set 2:

the pciutils target is to detect the presence of the libpci headers and print a message which libraries are probably missing; with this patch the detection/message doesn't get called any more and leaves dead code in the makefile. There is some BSD-specific case in the test tool that's embedded in the makefile (why?!), so without having really looked into that issue, I'd guess that the proper fix would either be fixing the test tool for your platform without or removing the now dead code in the makefile and adding the information to the readme. i'd be ok with both of those

-- To view, visit https://review.coreboot.org/c/coreboot/+/37768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Gerrit-Change-Number: 37768 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 18 Dec 2019 22:04:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Idwer Vollering (Code Review)

19 Dec 19 Dec

8:18 a.m.

New subject: Change in coreboot[master]: util/superiotool: alter Makefile to build the binary on FreeBSD

Hello Felix Held, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37768

to look at the new patch set (#3).

Change subject: util/superiotool: alter Makefile to build the binary on FreeBSD ......................................................................

util/superiotool: alter Makefile to build the binary on FreeBSD

With the 'pciutils' target inbetween, the PCI library (-lpci) can not be found even though it is installed.

Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/superiotool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/37768/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Gerrit-Change-Number: 37768 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Idwer Vollering (Code Review)

8:21 a.m.

New subject: Change in coreboot[master]: util/superiotool: alter Makefile to build the binary on FreeBSD

Hello Felix Held, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37768

to look at the new patch set (#4).

Change subject: util/superiotool: alter Makefile to build the binary on FreeBSD ......................................................................

util/superiotool: alter Makefile to build the binary on FreeBSD

Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/superiotool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/37768/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/37768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Gerrit-Change-Number: 37768 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Idwer Vollering (Code Review)

8:48 a.m.

New subject: Change in coreboot[master]: util/superiotool: alter Makefile to build the binary on FreeBSD

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37768 )

Change subject: util/superiotool: alter Makefile to build the binary on FreeBSD ......................................................................

Patch Set 4:

adding the offending author ;)

-- To view, visit https://review.coreboot.org/c/coreboot/+/37768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Gerrit-Change-Number: 37768 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 19 Dec 2019 16:48:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Held (Code Review)

22 Dec 22 Dec

5:50 a.m.

New subject: Change in coreboot[master]: util/superiotool: alter Makefile to build the binary on FreeBSD

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37768 )

Change subject: util/superiotool: alter Makefile to build the binary on FreeBSD ......................................................................

Patch Set 4: Code-Review+2

this shouldn't break anything on linux, but it would probably be good if someone can verify this before i submit this patch

-- To view, visit https://review.coreboot.org/c/coreboot/+/37768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Gerrit-Change-Number: 37768 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 22 Dec 2019 13:50:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

26 Dec 26 Dec

2:06 p.m.

New subject: Change in coreboot[master]: util/superiotool: alter Makefile to build the binary on FreeBSD

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37768 )

Change subject: util/superiotool: alter Makefile to build the binary on FreeBSD ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37768/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37768/1//COMMIT_MSG@7 PS1, Line 7: util/superiotool: build fix for FreeBSD

...

Please use a statement: […]

Done

https://review.coreboot.org/c/coreboot/+/37768/1//COMMIT_MSG@8 PS1, Line 8:

...

Please elaborate on the error that is fixed.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Gerrit-Change-Number: 37768 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 26 Dec 2019 22:06:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Felix Held (Code Review)

2:06 p.m.

New subject: Change in coreboot[master]: util/superiotool: alter Makefile to build the binary on FreeBSD

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37768 )

Change subject: util/superiotool: alter Makefile to build the binary on FreeBSD ......................................................................

util/superiotool: alter Makefile to build the binary on FreeBSD

Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Signed-off-by: Idwer Vollering vidwer@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37768 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M util/superiotool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved

diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile index 2bc88ab..32f4683 100644 --- a/util/superiotool/Makefile +++ b/util/superiotool/Makefile @@ -103,7 +103,7 @@ pciutils: @printf "\nChecking for pciutils and zlib... " @echo "$$LIBPCI_TEST" > .test.c - @$(CC) $(CFLAGS) .test.c -o .test $(LIBS) >/dev/null 2>&1 && \ + @$(CC) $(CFLAGS) .test.c -o .test $(LIBS) $(LDFLAGS) >/dev/null 2>&1 && \ printf "found.\n" || ( printf "not found.\n\n"; \ printf "Please install pciutils-devel and zlib-devel.\n"; \ printf "See README for more information.\n\n"; \

-- To view, visit https://review.coreboot.org/c/coreboot/+/37768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia96bee18abcdf278ae9178471cd4af2de454facf Gerrit-Change-Number: 37768 Gerrit-PatchSet: 5 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1861

days inactive

1871

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Felix Held (Code Review)
Idwer Vollering (Code Review)
Paul Menzel (Code Review)