Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support
......................................................................
Patch Set 18:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85126/comment/7207dc4f_a27dc841?usp... :
PS17, Line 13: TEST=build pass
Were you able to run-time test it? Maybe print the new log messages.
Done
File src/soc/mediatek/mt8196/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/85126/comment/84f610df_92f5e823?usp... :
PS17, Line 190: int
size_t
Done
https://review.coreboot.org/c/coreboot/+/85126/comment/f14786de_a50d48bc?usp... :
PS17, Line 345: spmi
SPMI
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85126?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I232015f45735ee5278b09d0352410617a1565177
Gerrit-Change-Number: 85126
Gerrit-PatchSet: 18
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 10 Dec 2024 09:43:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org