Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier, Varshit Pandya.
Nick Kochlowski has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85631?usp=email )
Change subject: drivers/amd/opensil: Add openSIL timepoint calls
......................................................................
Patch Set 7:
(3 comments)
File src/drivers/amd/opensil/Kconfig:
https://review.coreboot.org/c/coreboot/+/85631/comment/fcb10e31_2b4e5ee7?usp... :
PS6, Line 5: depends on SOC_AMD_OPENSIL
i asked for that one to be put back in some earlier version, but i don't have a super strong opinion […]
Done
File src/drivers/amd/opensil/opensil.h:
https://review.coreboot.org/c/coreboot/+/85631/comment/d01a5875_4ed0b4e9?usp... :
PS6, Line 3: _OPENSIL_DRIVER_H_
good point, now that i've thought about that one, i second that
Done
File src/soc/amd/phoenix/chip.c:
https://review.coreboot.org/c/coreboot/+/85631/comment/e1a06143_97c8ae00?usp... :
PS6, Line 3: /* TODO: Update for Phoenix */
i probably just forgot to remove that one. […]
Pushed a follow-on patch at the end of the chain that removes this comment from any relevant files!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85631?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0559fc0ff0ec55e9ef131e5ed20dfb5baa651da
Gerrit-Change-Number: 85631
Gerrit-PatchSet: 7
Gerrit-Owner: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 20 Dec 2024 20:53:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de