Attention is currently required from: Maulik V Vaghela, Paul Menzel, Tim Wawrzynczak, Subrata Banik, Kane Chen, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61678 )
Change subject: soc/intel/alderlake: Disable Energy Efficient Turbo for ADL ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61678/comment/c10885a5_f5b39775 PS1, Line 9: Max
max
Ack
https://review.coreboot.org/c/coreboot/+/61678/comment/3d2b3c50_edf9a740 PS1, Line 11:
- Can this operating system control that mode too? […]
The Energy Efficient Turbo is remain disabled in JSL and TGL. Performance KPIs do not hit turbo frequency if this feature is enabled.
https://review.coreboot.org/c/coreboot/+/61678/comment/6d3c8d5c_5981f0d9 PS1, Line 12: intensiv
`intensive`
Ack
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/61678/comment/ee9227d5_73171918 PS1, Line 658: * Disable the energy efficient turbo mode */ : s_cfg->EnergyEfficientTurbo = 0;
Looks like this is just setting a bit in MSR_POWER_CTL, could this just be moved to https://review. […]
With this feature, CPU doesn't hit turbo frequency when needed. So, all performance KPIs get effected.