Attention is currently required from: Martin Roth, jacz@semihalf.com, Jan Dabros. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50305 )
Change subject: tests: Add lib/stack-test test case ......................................................................
Patch Set 2:
(1 comment)
File tests/lib/stack-test.c:
https://review.coreboot.org/c/coreboot/+/50305/comment/27d79151_481d8998 PS1, Line 102: stack[i] = 0x42420707;
I do not think that size being even or odd changes anything in this situation. […]
I agree, the stack is almost always an even number of machine words, often a power of 2. But it's not a requirement, and I don't want the unit test to fail later when the stack size happens to be an odd number of machine words because I suggested an optimization in a unit test. That was a bad suggestion, so I prefer that it gets undone. The other option is to add a test_assert at the start of the test to check if the stack size is an even number of machine words.
-
Paul Fagerburg (Code Review)