Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35794 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/...
PS2, Line 65: Package () { 0, 0, 0, 0, 8, 0x200, "mA", 0 }, /* 0.5A */
Charge current 1.0A can get pass result of our thermal validation. […]
OK.
https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/...
PS2, Line 93: /* CPU Throttle Effect on CPU */
: Package () { _SB.PCI0.TCPU, _SB.PCI0.TCPU, 100, 60, 0, 0, 0, 0 },
We will remove it .
Are you planning to remove it in this same CL (with new patch set) or new CL ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e5c079856a167b1c2ef52e446d055404e565858
Gerrit-Change-Number: 35794
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anson Tseng
anson.tseng@intel.corp-partner.google.com
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Oct 2019 17:23:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-MessageType: comment