Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83913?usp=email )
Change subject: util/autoport: Assign SPD addresses in devicetree for Haswell ......................................................................
util/autoport: Assign SPD addresses in devicetree for Haswell
This corresponds to commit xxxxxxxxxxxx (nb/intel/haswell: Move SPD addresses to devicetree).
There is a FIXME comment added with a caveat similar to commit 496362d7e119 (util/autoport: Assign SPD addresses in devicetree) for sandybridge autoport.
Passes 'go build', but otherwise untested.
Change-Id: Ie32f6b1e79fd367e7ed2cf46e496b9c1ee813604 Signed-off-by: Keith Hui buurin@gmail.com --- M util/autoport/haswell.go M util/autoport/lynxpoint.go 2 files changed, 1 insertion(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/83913/1
diff --git a/util/autoport/haswell.go b/util/autoport/haswell.go index 588d271..668771b 100644 --- a/util/autoport/haswell.go +++ b/util/autoport/haswell.go @@ -65,6 +65,7 @@ "usb_xhci_on_resume": "false", /* FIXME:XX hardcoded. */ "gfx": "GMA_STATIC_DISPLAYS(0)", + "spd_addresses": "{0x50, 0x51, 0x52, 0x53}" # FIXME: Put proper SPD map here", }, Children: []DevTreeNode{ { diff --git a/util/autoport/lynxpoint.go b/util/autoport/lynxpoint.go index 98a1ca8..7168686 100644 --- a/util/autoport/lynxpoint.go +++ b/util/autoport/lynxpoint.go @@ -272,7 +272,6 @@ Add_gpl(sb) sb.WriteString(`#include <stdint.h> #include <northbridge/intel/haswell/haswell.h> -#include <northbridge/intel/haswell/raminit.h> #include <southbridge/intel/lynxpoint/pch.h>
void mainboard_config_rcba(void) @@ -284,15 +283,6 @@ { }
-void mb_get_spd_map(struct spd_info *spdi) -{ - /* FIXME: check this */ - spdi->addresses[0] = 0x50; - spdi->addresses[1] = 0x51; - spdi->addresses[2] = 0x52; - spdi->addresses[3] = 0x53; -} - const struct usb2_port_config mainboard_usb2_ports[MAX_USB2_PORTS] = { /* FIXME: Length and Location are computed from IOBP values, may be inaccurate */ /* Length, Enable, OCn#, Location */