Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74553 )
Change subject: soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison ......................................................................
soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison
Comparing an unsigned int to be smaller than 0 has no impact. This fixes a clang warning.
Change-Id: I12fccff2fb7d43fd4582afd518a7eab632908a5f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/mediatek/mt8195/apusys_devapc.c 1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/74553/1
diff --git a/src/soc/mediatek/mt8195/apusys_devapc.c b/src/soc/mediatek/mt8195/apusys_devapc.c index d5f8978..1f2b520 100644 --- a/src/soc/mediatek/mt8195/apusys_devapc.c +++ b/src/soc/mediatek/mt8195/apusys_devapc.c @@ -151,7 +151,7 @@ u32 apc_set_index; u32 *base;
- if (perm >= PERM_NUM || perm < 0) { + if (perm >= PERM_NUM || perm != 0) { printk(BIOS_ERR, "[NOC_DAPC] permission type:%#x is not supported!\n", perm); return APUSYS_APC_ERR_PERMISSION_NOT_SUPPORTED; } @@ -192,7 +192,7 @@ u32 apc_set_index; u32 *base;
- if (perm >= PERM_NUM || perm < 0) { + if (perm >= PERM_NUM || perm != 0) { printk(BIOS_ERR, "[APUAPC] perm type:%#x is not supported!\n", perm); return APUSYS_APC_ERR_PERMISSION_NOT_SUPPORTED; }