Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35522 )
Change subject: buildgcc: Run aclocal before configure ......................................................................
buildgcc: Run aclocal before configure
Ubuntu 19.04 will fail looking for aclocal-1.15 if the scripts are not regenerated because 19.04 ships with 1.16. There are not enough eyes to roll when working with GNU autotools.
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I4aa9f520499930ffc984ab0b0144c9c6b2e544a0 --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35522/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 9c10c7d..a16d670 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -893,6 +893,7 @@ }
build_MAKE() { + ( cd ../${MAKE_DIR}/ && aclocal && autoconf ) CC="$(hostcc host)" CXX="$(hostcxx host)" CFLAGS="$HOSTCFLAGS" \ ../${MAKE_DIR}/configure --prefix="$TARGETDIR" --disable-nls \ || touch .failed
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35522 )
Change subject: buildgcc: Run aclocal before configure ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has uploaded a new patch set (#2) to the change originally created by Stefan Reinauer. ( https://review.coreboot.org/c/coreboot/+/35522 )
Change subject: buildgcc: Run aclocal before configure ......................................................................
buildgcc: Run aclocal before configure
Ubuntu 19.04 will fail looking for aclocal-1.15 if the scripts are not regenerated because 19.04 ships with 1.16. There are not enough eyes to roll when working with GNU autotools.
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I4aa9f520499930ffc984ab0b0144c9c6b2e544a0 --- M util/crossgcc/buildgcc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35522/2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35522 )
Change subject: buildgcc: Run aclocal before configure ......................................................................
Patch Set 2: Code-Review+2
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35522 )
Change subject: buildgcc: Run aclocal before configure ......................................................................
buildgcc: Run aclocal before configure
Ubuntu 19.04 will fail looking for aclocal-1.15 if the scripts are not regenerated because 19.04 ships with 1.16. There are not enough eyes to roll when working with GNU autotools.
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I4aa9f520499930ffc984ab0b0144c9c6b2e544a0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35522 Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 9c10c7d..6c378ac 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -893,9 +893,11 @@ }
build_MAKE() { + ( cd ../${MAKE_DIR}/ && aclocal && autoconf ) CC="$(hostcc host)" CXX="$(hostcxx host)" CFLAGS="$HOSTCFLAGS" \ ../${MAKE_DIR}/configure --prefix="$TARGETDIR" --disable-nls \ || touch .failed + $MAKE -k clean # shellcheck disable=SC2086 $MAKE $JOBS || touch .failed $MAKE install DESTDIR=$DESTDIR || touch .failed
-
Martin Roth (Code Review) -
Stefan Reinauer (Code Review)