Change in coreboot[master]: soc/intel/common: Add bootblock common stage file

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18457 )

Change subject: soc/intel/common: Add bootblock common stage file
......................................................................

Patch Set 33:
> Patch Set 33:
> > Patch Set 33:
> > > Patch Set 33:
> > > > Patch Set 33:
> > > >
> > > > with CB:36711 cpu/intel/car/bootblock.c you have prototypes to more or less do the same. Maybe you can reuse it?
> > >
> > > I am skeptical to move the SoC init into "cpu"/intel/car since this encompasses multiple IPs like SA and MCH and not only CPU.
> >
> > It already covers those multiple IPs. It could be placed into arch/x86 if you think that is a better place (it's not very Intel specific indeed).
>
> HI Arthur,
>
> Your point is very valid and for that reason only we have created this "src/soc/intel/common/basecode/" to handle non-IP code block which has just glue logic to call various IP from "src/soc/intel/common/block/".
>
> Right now Intel common code model has supported SOC starting from SKL till latest and all exist inside "src/soc/intel/common/block" hence keeping glue/non-IP code into "src/soc/intel/common/basecode/" makes more reasonable to me. I hope you will agree to this as well.
>
> Thanks,
> Subrata

Hi

I don't understand it. Why would you want to replicate more or less existing glue logic just to keep things in a dir? There is a similar thing happening for the romstage entry which is common to all Intel targets and resides in cpu/intel/car/romstage.c.