Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Paul Menzel, Pratikkumar V Prajapati.
Filip Lewiński has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81843?usp=email )
Change subject: util/inteltool: add Meteor Lake support
......................................................................
Patch Set 19:
(2 comments)
File util/inteltool/gpio_names/meteorlake.h:
https://review.coreboot.org/c/coreboot/+/81843/comment/59d7d551_2cc1ea70 :
PS18, Line 349: "VGPIO3_USB0", "VGPIO3_USB0",
These pads are called `GPP_VGPIO3_*` in coreboot. […]
[Done](https://review.coreboot.org/c/coreboot/+/81843/18..19/util/inteltool/gpio_na...)
https://review.coreboot.org/c/coreboot/+/81843/comment/a74fdbff_e9d17129 :
PS18, Line 395: "VGPIO00", "VGPIO00",
a/a, I think these should be `GPP_VGPIO*`
[Done](https://review.coreboot.org/c/coreboot/+/81843/18..19/util/inteltool/gpio_na...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81843?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7473119fa97c57cd2a1303f08f964abd0ca96270
Gerrit-Change-Number: 81843
Gerrit-PatchSet: 19
Gerrit-Owner: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Wed, 08 May 2024 12:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-MessageType: comment