Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56921 )
Change subject: mb/google/guybrush: Create nipperkin variant ......................................................................
mb/google/guybrush: Create nipperkin variant
Create the nipperkin variant of the guybrush reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0.)
BUG=None BRANCH=None TEST=util/abuild/abuild -p none -t google/guybrush -x -a make sure the build includes GOOGLE_NIPPERKIN
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: Ie525ea501e6c3d5d94e67c1db1d4e307fb7ccba7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56921 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Bhanu Prakash Maiya bhanumaiya@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/guybrush/Kconfig.name A src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc A src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h A src/mainboard/google/guybrush/variants/nipperkin/include/variant/gpio.h A src/mainboard/google/guybrush/variants/nipperkin/memory/Makefile.inc A src/mainboard/google/guybrush/variants/nipperkin/memory/dram_id.generated.txt A src/mainboard/google/guybrush/variants/nipperkin/memory/mem_parts_used.txt A src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb 9 files changed, 39 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Fagerburg: Looks good to me, approved Bhanu Prakash Maiya: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index 17cdada..2da9230 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -72,6 +72,7 @@
config MAINBOARD_PART_NUMBER default "Guybrush" if BOARD_GOOGLE_GUYBRUSH + default "Nipperkin" if BOARD_GOOGLE_NIPPERKIN
config AMD_FWM_POSITION_INDEX int @@ -103,6 +104,7 @@
config VARIANT_DIR default "guybrush" if BOARD_GOOGLE_GUYBRUSH + default "nipperkin" if BOARD_GOOGLE_NIPPERKIN
config DEVICETREE default "variants/baseboard/devicetree.cb" diff --git a/src/mainboard/google/guybrush/Kconfig.name b/src/mainboard/google/guybrush/Kconfig.name index 076516c..edddbf8 100644 --- a/src/mainboard/google/guybrush/Kconfig.name +++ b/src/mainboard/google/guybrush/Kconfig.name @@ -3,3 +3,7 @@ config BOARD_GOOGLE_GUYBRUSH bool "-> Guybrush" select BOARD_GOOGLE_BASEBOARD_GUYBRUSH + +config BOARD_GOOGLE_NIPPERKIN + bool "-> Nipperkin" + select BOARD_GOOGLE_BASEBOARD_GUYBRUSH diff --git a/src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc b/src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc new file mode 100644 index 0000000..88e75bd --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +subdirs-y += ./memory diff --git a/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/guybrush/variants/nipperkin/include/variant/gpio.h b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/gpio.h new file mode 100644 index 0000000..dfaeec3 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/gpio.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> diff --git a/src/mainboard/google/guybrush/variants/nipperkin/memory/Makefile.inc b/src/mainboard/google/guybrush/variants/nipperkin/memory/Makefile.inc new file mode 100644 index 0000000..b0ca222 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = placeholder.spd.hex diff --git a/src/mainboard/google/guybrush/variants/nipperkin/memory/dram_id.generated.txt b/src/mainboard/google/guybrush/variants/nipperkin/memory/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/memory/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/src/mainboard/google/guybrush/variants/nipperkin/memory/mem_parts_used.txt b/src/mainboard/google/guybrush/variants/nipperkin/memory/mem_parts_used.txt new file mode 100644 index 0000000..8124e4f --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/memory/mem_parts_used.txt @@ -0,0 +1,11 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Generated IDs are dependent on the order of parts in this file, +# so new parts must always be added at the end of the file! +# +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/{ddr4,lp4x}. +# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. + +# Part Name, Fixed ID (optional) diff --git a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb new file mode 100644 index 0000000..c182265 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/cezanne + device domain 0 on + + end # domain +end # chip soc/amd/cezanne