Attention is currently required from: Martin L Roth, Marvin Evers, Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79439?usp=email )
Change subject: mb/google/poppy: Use chipset dt reference names ......................................................................
Patch Set 8:
(9 comments)
File src/mainboard/google/poppy/variants/atlas/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79439/comment/bd041630_f50fb153 : PS6, Line 264: on
tab
Done
https://review.coreboot.org/c/coreboot/+/79439/comment/1bc993b0_6ac0ed5d : PS6, Line 281: off end : device ref i2c2 on
tab these out to match reset of file
Done
https://review.coreboot.org/c/coreboot/+/79439/comment/2311ff6e_a12812b5 : PS6, Line 301: device ref i2c4 on
tab
Done
https://review.coreboot.org/c/coreboot/+/79439/comment/bc183456_a931dd6f : PS6, Line 335: # Audio
Remove superfluous comment.
Done
https://review.coreboot.org/c/coreboot/+/79439/comment/bec29a34_14c39c6f : PS6, Line 336: on
tab
Done
https://review.coreboot.org/c/coreboot/+/79439/comment/c23236cf_ad36766c : PS6, Line 355: on
tab
Done
https://review.coreboot.org/c/coreboot/+/79439/comment/27e96908_d22da114 : PS6, Line 367: on
tab
Done
File src/mainboard/google/poppy/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79439/comment/6e8c47ea_56cb9691 : PS6, Line 254: o
align all on/off entries one tab stop left of here
Done
File src/mainboard/google/poppy/variants/nami/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79439/comment/b4a8e8f2_2d95045d : PS6, Line 286: on
please use consistent tabbing of on/off throughout the file
Done