Attention is currently required from: Angel Pons, Patrick Rudolph.
Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51096 )
Change subject: soc/intel/tigerlake: Re-use existing define in CrashLog implementation
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Please add some config to build-test the crashlog code.
There is already one named SOC_INTEL_COMMON_BLOCK_CRASHLOG inside
src/soc/intel/tigerlake/Kconfig.
For now it is set to no. After this CL merges, you can set it to yes and build it locally. The feature is to be turned off by default on TGL. It will be turn on by default on ADL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51096
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If063d1ea4189dbc5a75f37d86ce158e8f1bd808d
Gerrit-Change-Number: 51096
Gerrit-PatchSet: 4
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 01 Mar 2021 21:00:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment