Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84189?usp=email )
Change subject: soc/intel/meteorlake: Remove unused pch_handle_sideband() function ......................................................................
soc/intel/meteorlake: Remove unused pch_handle_sideband() function
This change removes the unused pch_handle_sideband() function from the Meteor Lake platform code.
TEST=Able to build and boot google/rex.
Change-Id: Idd14748aa1d917d6e88d738541a737c04a2c6a15 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84189 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Pratikkumar V Prajapati pratikkumar.v.prajapati@intel.com --- M src/soc/intel/meteorlake/finalize.c 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: Eric Lai: Looks good to me, approved Pratikkumar V Prajapati: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/intel/meteorlake/finalize.c b/src/soc/intel/meteorlake/finalize.c index ed29ba9..1fd1d98 100644 --- a/src/soc/intel/meteorlake/finalize.c +++ b/src/soc/intel/meteorlake/finalize.c @@ -23,21 +23,13 @@ #include <soc/soc_chip.h> #include <soc/systemagent.h>
-static void pch_handle_sideband(config_t *config) -{ -} - static void pch_finalize(void) { - config_t *config = config_of_soc(); - /* TCO Lock down */ tco_lockdown();
/* TODO: Add Thermal Configuration */
- pch_handle_sideband(config); - pmc_clear_pmcon_sts(); }