Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42647 )
Change subject: sb/intel/i82801ix/Kconfig: Sort options alphabetically ......................................................................
sb/intel/i82801ix/Kconfig: Sort options alphabetically
Tested with BUILD_TIMELESS=1, Roda RK9 remains identical.
Change-Id: I6f49af457f104dbf73e156f46ce09103ca9dccdb Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/i82801ix/Kconfig 1 file changed, 17 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/42647/1
diff --git a/src/southbridge/intel/i82801ix/Kconfig b/src/southbridge/intel/i82801ix/Kconfig index 9e71ff5..bd2cd0f4 100644 --- a/src/southbridge/intel/i82801ix/Kconfig +++ b/src/southbridge/intel/i82801ix/Kconfig @@ -2,23 +2,23 @@
config SOUTHBRIDGE_INTEL_I82801IX bool - select SOUTHBRIDGE_INTEL_COMMON_SMBUS - select SOUTHBRIDGE_INTEL_COMMON_SPI_ICH9 if !BOARD_EMULATION_QEMU_X86_Q35 - select SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ - select SOUTHBRIDGE_INTEL_COMMON_PMBASE - select SOUTHBRIDGE_INTEL_COMMON_RTC - select SOUTHBRIDGE_INTEL_COMMON_RESET - select IOAPIC - select USE_WATCHDOG_ON_BOOT + select ACPI_INTEL_HARDWARE_SLEEP_VALUES select HAVE_SMI_HANDLER select HAVE_USBDEBUG_OPTIONS - select SOUTHBRIDGE_INTEL_COMMON_GPIO - select SOUTHBRIDGE_INTEL_COMMON_SMM - select SOUTHBRIDGE_INTEL_COMMON_PMCLIB select INTEL_DESCRIPTOR_MODE_CAPABLE - select ACPI_INTEL_HARDWARE_SLEEP_VALUES - select SOUTHBRIDGE_INTEL_COMMON_WATCHDOG + select IOAPIC + select SOUTHBRIDGE_INTEL_COMMON_GPIO + select SOUTHBRIDGE_INTEL_COMMON_PMBASE + select SOUTHBRIDGE_INTEL_COMMON_PMCLIB + select SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ + select SOUTHBRIDGE_INTEL_COMMON_RESET + select SOUTHBRIDGE_INTEL_COMMON_RTC + select SOUTHBRIDGE_INTEL_COMMON_SMBUS + select SOUTHBRIDGE_INTEL_COMMON_SMM + select SOUTHBRIDGE_INTEL_COMMON_SPI_ICH9 if !BOARD_EMULATION_QEMU_X86_Q35 select SOUTHBRIDGE_INTEL_COMMON_USB_DEBUG + select SOUTHBRIDGE_INTEL_COMMON_WATCHDOG + select USE_WATCHDOG_ON_BOOT
if SOUTHBRIDGE_INTEL_I82801IX
@@ -26,13 +26,13 @@ hex default 0xfef00000
+config HPET_MIN_TICKS + hex + default 0x80 + ## Some enterprise variants may require an IFD config INTEL_DESCRIPTOR_MODE_REQUIRED bool default n
-config HPET_MIN_TICKS - hex - default 0x80 - endif
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42647 )
Change subject: sb/intel/i82801ix/Kconfig: Sort options alphabetically ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42647 )
Change subject: sb/intel/i82801ix/Kconfig: Sort options alphabetically ......................................................................
sb/intel/i82801ix/Kconfig: Sort options alphabetically
Tested with BUILD_TIMELESS=1, Roda RK9 remains identical.
Change-Id: I6f49af457f104dbf73e156f46ce09103ca9dccdb Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42647 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/i82801ix/Kconfig 1 file changed, 17 insertions(+), 17 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/southbridge/intel/i82801ix/Kconfig b/src/southbridge/intel/i82801ix/Kconfig index 9e71ff5..bd2cd0f4 100644 --- a/src/southbridge/intel/i82801ix/Kconfig +++ b/src/southbridge/intel/i82801ix/Kconfig @@ -2,23 +2,23 @@
config SOUTHBRIDGE_INTEL_I82801IX bool - select SOUTHBRIDGE_INTEL_COMMON_SMBUS - select SOUTHBRIDGE_INTEL_COMMON_SPI_ICH9 if !BOARD_EMULATION_QEMU_X86_Q35 - select SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ - select SOUTHBRIDGE_INTEL_COMMON_PMBASE - select SOUTHBRIDGE_INTEL_COMMON_RTC - select SOUTHBRIDGE_INTEL_COMMON_RESET - select IOAPIC - select USE_WATCHDOG_ON_BOOT + select ACPI_INTEL_HARDWARE_SLEEP_VALUES select HAVE_SMI_HANDLER select HAVE_USBDEBUG_OPTIONS - select SOUTHBRIDGE_INTEL_COMMON_GPIO - select SOUTHBRIDGE_INTEL_COMMON_SMM - select SOUTHBRIDGE_INTEL_COMMON_PMCLIB select INTEL_DESCRIPTOR_MODE_CAPABLE - select ACPI_INTEL_HARDWARE_SLEEP_VALUES - select SOUTHBRIDGE_INTEL_COMMON_WATCHDOG + select IOAPIC + select SOUTHBRIDGE_INTEL_COMMON_GPIO + select SOUTHBRIDGE_INTEL_COMMON_PMBASE + select SOUTHBRIDGE_INTEL_COMMON_PMCLIB + select SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ + select SOUTHBRIDGE_INTEL_COMMON_RESET + select SOUTHBRIDGE_INTEL_COMMON_RTC + select SOUTHBRIDGE_INTEL_COMMON_SMBUS + select SOUTHBRIDGE_INTEL_COMMON_SMM + select SOUTHBRIDGE_INTEL_COMMON_SPI_ICH9 if !BOARD_EMULATION_QEMU_X86_Q35 select SOUTHBRIDGE_INTEL_COMMON_USB_DEBUG + select SOUTHBRIDGE_INTEL_COMMON_WATCHDOG + select USE_WATCHDOG_ON_BOOT
if SOUTHBRIDGE_INTEL_I82801IX
@@ -26,13 +26,13 @@ hex default 0xfef00000
+config HPET_MIN_TICKS + hex + default 0x80 + ## Some enterprise variants may require an IFD config INTEL_DESCRIPTOR_MODE_REQUIRED bool default n
-config HPET_MIN_TICKS - hex - default 0x80 - endif
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)