Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43318 )
Change subject: mb/google/kukui: Add new configs 'willow' ......................................................................
mb/google/kukui: Add new configs 'willow'
New boards introduced to Kukui family.
BUG=b:159194582 TEST=None
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Icc6bcbd006008a05303693e481a54636f0645887 --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/43318/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 4c8ebbf..de78e91 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -29,7 +29,7 @@ select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI - select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA + select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA || BOARD_GOOGLE_WILLOW select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE
config MAINBOARD_DIR @@ -47,6 +47,7 @@ default "Juniper" if BOARD_GOOGLE_JUNIPER default "Kappa" if BOARD_GOOGLE_KAPPA default "Damu" if BOARD_GOOGLE_DAMU + default "Willow" if BOARD_GOOGLE_WILLOW
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 4b12034..dcf8c70 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -35,3 +35,7 @@ config BOARD_GOOGLE_DAMU bool "-> Damu" select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_WILLOW + bool "-> Willow" + select BOARD_GOOGLE_KUKUI_COMMON
Chen-Tsung Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43318 )
Change subject: mb/google/kukui: Add new configs 'willow' ......................................................................
Patch Set 1: Code-Review+1
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43318 )
Change subject: mb/google/kukui: Add new configs 'willow' ......................................................................
Patch Set 1:
(1 comment)
LGTM after you added the BRANCH
https://review.coreboot.org/c/coreboot/+/43318/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43318/1//COMMIT_MSG@12 PS1, Line 12: TEST=None Please add BRANCH=kukui
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43318 )
Change subject: mb/google/kukui: Add new configs 'willow' ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43318/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43318/1//COMMIT_MSG@7 PS1, Line 7: configs Only one "config"?
https://review.coreboot.org/c/coreboot/+/43318/1//COMMIT_MSG@9 PS1, Line 9: boards board
Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh, Chen-Tsung Hsieh, Tim Chen, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43318
to look at the new patch set (#2).
Change subject: mb/google/kukui: Add new config 'willow' ......................................................................
mb/google/kukui: Add new config 'willow'
New board introduced to Kukui family.
BUG=b:159194582 TEST=None BRANCH=kukui
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Icc6bcbd006008a05303693e481a54636f0645887 --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/43318/2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43318 )
Change subject: mb/google/kukui: Add new config 'willow' ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/43318/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43318/1//COMMIT_MSG@7 PS1, Line 7: configs
Only one "config"?
Done
https://review.coreboot.org/c/coreboot/+/43318/1//COMMIT_MSG@9 PS1, Line 9: boards
board
Done
https://review.coreboot.org/c/coreboot/+/43318/1//COMMIT_MSG@12 PS1, Line 12: TEST=None
Please add BRANCH=kukui
Done
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43318 )
Change subject: mb/google/kukui: Add new config 'willow' ......................................................................
Patch Set 2: Code-Review+2
Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh, Chen-Tsung Hsieh, Tim Chen, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43318
to look at the new patch set (#3).
Change subject: mb/google/kukui: Add new configs 'willow' ......................................................................
mb/google/kukui: Add new configs 'willow'
New boards introduced to Kukui family.
BUG=b:159194582 TEST=None
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Icc6bcbd006008a05303693e481a54636f0645887 --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/43318/3
Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh, Chen-Tsung Hsieh, Tim Chen, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43318
to look at the new patch set (#4).
Change subject: mb/google/kukui: Add new config 'willow' ......................................................................
mb/google/kukui: Add new config 'willow'
New board introduced to Kukui family.
BUG=b:159194582 TEST=None
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Icc6bcbd006008a05303693e481a54636f0645887 --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/43318/4
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43318 )
Change subject: mb/google/kukui: Add new config 'willow' ......................................................................
Patch Set 4: Code-Review+2
Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh, Chen-Tsung Hsieh, Tim Chen, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43318
to look at the new patch set (#5).
Change subject: mb/google/kukui: Add new config 'willow' ......................................................................
mb/google/kukui: Add new config 'willow'
New board introduced to Kukui family.
BUG=b:159194582 TEST=None BRANCH=kukui
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Icc6bcbd006008a05303693e481a54636f0645887 --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/43318/5
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43318 )
Change subject: mb/google/kukui: Add new config 'willow' ......................................................................
mb/google/kukui: Add new config 'willow'
New board introduced to Kukui family.
BUG=b:159194582 TEST=None BRANCH=kukui
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Icc6bcbd006008a05303693e481a54636f0645887 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43318 Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index fa76796..f390147 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -29,7 +29,7 @@ select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI - select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA || BOARD_GOOGLE_CERISE || BOARD_GOOGLE_STERN + select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA || BOARD_GOOGLE_CERISE || BOARD_GOOGLE_STERN || BOARD_GOOGLE_WILLOW select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE
config MAINBOARD_DIR @@ -49,6 +49,7 @@ default "Damu" if BOARD_GOOGLE_DAMU default "Cerise" if BOARD_GOOGLE_CERISE default "Stern" if BOARD_GOOGLE_STERN + default "Willow" if BOARD_GOOGLE_WILLOW
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 22130e5..55e0101 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -43,3 +43,7 @@ config BOARD_GOOGLE_STERN bool "-> Stern" select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_WILLOW + bool "-> Willow" + select BOARD_GOOGLE_KUKUI_COMMON
-
Chen-Tsung Hsieh (Code Review) -
Hung-Te Lin (Code Review)
-
Sheng-Liang Pan (Code Review)
-
Yu-Ping Wu (Code Review)