Attention is currently required from: Nico Huber, Tim Wawrzynczak, Nick Vaccaro. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table ......................................................................
Patch Set 28:
(4 comments)
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/5b80b410_d068fc4d PS26, Line 173: struct cb_type_c_info { This is not needed as well.
File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/bae16f03_16c3e5cb PS26, Line 153: typec_orientation type_c_orientation. However, the last line of the comment might not be necessary as this comment already is added to type_c_port_info.
File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/4d6ad2da_b67b38e4 PS26, Line 251: get_cbmem_addr (void *)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/d0ebd165_adbe0a66 PS27, Line 431: enum type_c_orientation { You will have to pull in the change to src/drivers/intel/pmc_mux/conn/chip.h into this CL, else compilation would fail for volteer.