Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84047?usp=email )
Change subject: soc/intel/apl: Fix building with clang & LTO ......................................................................
soc/intel/apl: Fix building with clang & LTO
LTO does not like that assert on a constant, so use the more appropriate static assertion.
Change-Id: I52094ec825fcec56a9b9fb6b9abc58644c2bf9cb Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/84047 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sean Rhodes sean@starlabs.systems Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/apollolake/romstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Sean Rhodes: Looks good to me, approved Nico Huber: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index f710883..d8d11a0 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -319,7 +319,7 @@ mrc_cache_current_mmap_leak(MRC_VARIABLE_DATA, version, NULL);
- assert(CONFIG(BOOT_DEVICE_MEMORY_MAPPED)); + _Static_assert(CONFIG(BOOT_DEVICE_MEMORY_MAPPED), "Boot device not memory mapped");
fsp_version = version; }