Attention is currently required from: Arthur Heymans, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64342 )
Change subject: cpu/x86/mp_init.c: Keep track of initial lapic ID inside device_path
......................................................................
Patch Set 15:
(2 comments)
File src/device/cpu_device.c:
https://review.coreboot.org/c/coreboot/+/64342/comment/7f23f1fb_a58f0df6
PS15, Line 10: struct device_path cpu_path;
The structure is not zero-initialized? Unrelated to this commit, separate fix?
https://review.coreboot.org/c/coreboot/+/64342/comment/18815461_3d2dd841
PS15, Line 33: void set_cpu_topology(struct device *cpu, unsigned int node,
Currently nobody calls this to address the uninitialized fields from above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64342
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d9f8d23c0b0e5c142f6907593428d8509e4e7bb
Gerrit-Change-Number: 64342
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 13 Nov 2022 21:39:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment