Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp ......................................................................
Patch Set 5:
(7 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/47379612_42b4bb37?usp... : PS1, Line 56: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) {
You can still use FW_CONFIG in depthcharge. […]
Done
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/6cfd17b4_dfc7ea2c?usp... : PS2, Line 56: GERALT_USE_MAX98390
This Kconfig option should be removed from mainboard/google/geralt/Kconfig.
Done
https://review.coreboot.org/c/coreboot/+/83287/comment/0e36754e_16770b3d?usp... : PS2, Line 7: #include <fw_config.h>
Sort
Done
File src/mainboard/google/geralt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83287/comment/8fa1ecd5_47167efa?usp... : PS2, Line 6:
One space.
Done
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/b42916bc_741bb5b5?usp... : PS2, Line 12: #include <fw_config.h>
Sort.
Done
https://review.coreboot.org/c/coreboot/+/83287/comment/3dc9e30b_dd46236d?usp... : PS2, Line 33: {
Skip if `CONFIG(GERALT_USE_NAU8318)`.
Done
https://review.coreboot.org/c/coreboot/+/83287/comment/4d78c431_7362dac6?usp... : PS2, Line 39: } : else if
`} else if`
Done