Change in coreboot[master]: rules.h, thread.h, lib/cbfs: Add ENV_STAGE_SUPPORTS_COOP - coreboot-gerrit

30 Nov 2021


      Attention is currently required from: Julius Werner.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59550 )
Change subject: rules.h, thread.h, lib/cbfs: Add ENV_STAGE_SUPPORTS_COOP
......................................................................
Patch Set 1:
(1 comment)
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/59550/comment/d028fbe6_f9d86d5a 
PS1, Line 306: ENV_ROMSTAGE
...
When cbfs_preload executes it stores a copy of the rdev. This should in theory be the "RO" rdev. […]
I just had another thought. This ENV_ is for COOP and not CBFS. So maybe we add the `(ENV_ROMSTAGE && !CONFIG(VBOOT_STARTS_IN_ROMSTAGE)) ` check into `cbfs_preload`?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59550
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1197406d1d36391998b08e3076146bb2fff59d00
Gerrit-Change-Number: 59550
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Tue, 30 Nov 2021 20:21:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment