Attention is currently required from: Nico Huber, Paul Fagerburg, Julius Werner, Yu-Ping Wu. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58242 )
Change subject: libpayload: Add unit-tests framework and first test case ......................................................................
Patch Set 5:
(1 comment)
File payloads/libpayload/tests/Makefile.inc:
PS4:
Changes you make in tests/Makefile.inc (to fix bugs, to add features) must now be synced up with this Makefile
True, but libpayload has separate build system. Look at coreboot/Makefile and libpayload/Makefile. Event tests of libpayload in util/testing/Makefile.inc are executed with `cd` at the beginning. Moreover, in the near future libpayload might require vboot (in some builds), so it will complicate things when it comes to test targets generation and their dependencies. For me it is easier to keep a copy of a test Makefile.inc in libpayload than to combine them both in one place. I cannot see more pros of merging those two, than (arguably) simpler maintenance. But if you have other arguments in favor of single framework for coreboot and libpayload, then tell me :)