Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60305 )
Change subject: mb/intel/{adlrvp,sm}: Remove unused header `helpers.h` ......................................................................
mb/intel/{adlrvp,sm}: Remove unused header `helpers.h`
This patch removes unused header inclusion as <commonlib/helpers.h> from several mainboard gpio definition files.
Change-Id: I36758089a4981bba916f4d9cf485f64fca2f81ae Signed-off-by: subratabanik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/60305 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/intel/adlrvp/early_gpio.c M src/mainboard/intel/adlrvp/early_gpio_m.c M src/mainboard/intel/adlrvp/gpio_m.c M src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c 4 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/intel/adlrvp/early_gpio.c b/src/mainboard/intel/adlrvp/early_gpio.c index 5af355b..57cadfa 100644 --- a/src/mainboard/intel/adlrvp/early_gpio.c +++ b/src/mainboard/intel/adlrvp/early_gpio.c @@ -2,7 +2,6 @@
#include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <commonlib/helpers.h> #include <soc/gpio.h>
/* Early pad configuration in bootblock */ diff --git a/src/mainboard/intel/adlrvp/early_gpio_m.c b/src/mainboard/intel/adlrvp/early_gpio_m.c index 3798593..fbc6467 100644 --- a/src/mainboard/intel/adlrvp/early_gpio_m.c +++ b/src/mainboard/intel/adlrvp/early_gpio_m.c @@ -2,7 +2,6 @@
#include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <commonlib/helpers.h> #include <soc/gpio.h>
/* Early pad configuration in bootblock */ diff --git a/src/mainboard/intel/adlrvp/gpio_m.c b/src/mainboard/intel/adlrvp/gpio_m.c index 6eb670b..62ae0f3 100644 --- a/src/mainboard/intel/adlrvp/gpio_m.c +++ b/src/mainboard/intel/adlrvp/gpio_m.c @@ -2,7 +2,6 @@
#include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <commonlib/helpers.h>
/* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { diff --git a/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c b/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c index 6a74468..ea05b89 100644 --- a/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c +++ b/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c @@ -2,7 +2,6 @@
#include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <commonlib/helpers.h>
/* Early pad configuration in bootblock */ static const struct pad_config early_gpio_table[] = {
-
Subrata Banik (Code Review)