Attention is currently required from: Furquan Shaikh, Brandon Breitenstein, Patrick Rudolph. Brandon Breitenstein has uploaded a new patch set (#2) to the change originally created by Furquan Shaikh. ( https://review.coreboot.org/c/coreboot/+/51232 )
Change subject: soc/intel/tigerlake: Fix NULL being passed for response buffer ......................................................................
soc/intel/tigerlake: Fix NULL being passed for response buffer
`pmc_send_ipc_cmd()` expects the caller to pass in a pointer to a valid request and response buffer. However, early_tcss driver was passing in a NULL pointer for response buffer which would result in invalid access by `pmc_send_ipc_cmd()`.
Currently, the response buffer is not used in `update_tcss_mux()`. So, this change drops the passing of `rbuf` parameter to `send_pmc*` helpers and instead uses a local `rsp` variable in the respective functions. All the PMC functions used in early_tcss driver return some kind of response. These should be checked to return appropriate response code back to the caller. However, this needs to be done as a separate change.
Change-Id: I215af85feed60b6beee17f28e3d65daa9ad4ae69 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/tigerlake/early_tcss.c 1 file changed, 14 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/51232/2