Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, sridhar siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80362?usp=email )
Change subject: soc/intel/cmn/sa: Add APIs into System Agent (SA) common code ......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/80362/comment/3cb5a7b4_21b6ad9b : PS6, Line 327: const struct device *dev
You know which device the sa. […]
SA is nothing but PCI_0_00_0 aka host bridge.
are you suggesting to use rather passing the `dev` argument to the function?
``` struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT); ```
https://review.coreboot.org/c/coreboot/+/80362/comment/60e6f259_e927845f : PS6, Line 432: sa_get_dpr_size
txt_get_chipset_dpr() in systemagent_early.c does the same.
good candidate for the convergence at some point. At least it covers the raw read from the register (like what line#435 does below) and additionally, this function returning the size in MiB (which may not be needed for early code piece).
I will pick that later for convergence. hoping u r good with that plan ?