Attention is currently required from: YH Lin, Tim Wawrzynczak, Zhuohao Lee, Felix Held.
Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63013 )
Change subject: drivers/net/r8168: Add support for Realtek RTL8111K
......................................................................
Patch Set 4:
(3 comments)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/63013/comment/60944f92_5bda1d8a
PS2, Line 1301: #define PCI_DID_REALTEK_8111 0x8111
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/63013/comment/40095659_cd6d2199
PS2, Line 1302: #define PCI_DID_REALTEK_8125 0x8125
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/63013/comment/324cccba_a6cf52e5
PS2, Line 1305: #define PCI_DID_REALTEK_8168 0x8168
please, no space before tabs
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63013
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ad8f14483393d6f25026847cc0d4229d362bba0
Gerrit-Change-Number: 63013
Gerrit-PatchSet: 4
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 23 Mar 2022 03:39:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment