[M] Change in coreboot[master]: soc/amd/common/psp_verstage: Map/unmap boot device on need basis

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74606 )

Change subject: soc/amd/common/psp_verstage: Map/unmap boot device on need basis
......................................................................

Patch Set 1:

(3 comments)

File src/soc/amd/common/psp_verstage/boot_dev.c:

https://review.coreboot.org/c/coreboot/+/74606/comment/62baa86c_df99393a 
PS1, Line 22: svc_map_spi_rom
> Will this set mapping to NULL on failure?

I expect SVC call to not touch mapping on failure. Do you think setting explicitly to NULL again might be safe?

https://review.coreboot.org/c/coreboot/+/74606/comment/bdf51c9d_485785b0 
PS1, Line 22: size
> Does this have any alignment restrictions?

Not that I am aware of. I can check with PSP team.

File src/soc/amd/common/psp_verstage/fch.c:

https://review.coreboot.org/c/coreboot/+/74606/comment/91e244b0_20a20219 
PS1, Line 100: SpiBiosSmnBase
> Is this really a `void *`?

Atleast as per the command structure defined in bl_syscall_public.h - https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/hea...