John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42955 )
Change subject: mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp ......................................................................
mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp
This change allows EC to change state of host-controlled USB MUX.
TEST=Built image and booted to kernel.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ia7c331157b1b4039e42c373f5b130a66f7594458 --- M src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/42955/1
diff --git a/src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h b/src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h index f05cb77..cbdb423 100644 --- a/src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h @@ -21,7 +21,8 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX))
#define MAINBOARD_EC_SMI_EVENTS \ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED))
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42955 )
Change subject: mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42955/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/42955/1/src/mainboard/intel/tglrvp/... PS1, Line 24: no tabs here for consistency.
Hello build bot (Jenkins), Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Duncan Laurie, Shamile Khan, Brandon Breitenstein, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42955
to look at the new patch set (#2).
Change subject: mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp ......................................................................
mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp
This change allows EC to change state of host-controlled USB MUX.
TEST=Built image and booted to kernel.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ia7c331157b1b4039e42c373f5b130a66f7594458 --- M src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/42955/2
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42955 )
Change subject: mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42955/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/42955/1/src/mainboard/intel/tglrvp/... PS1, Line 24:
no tabs here for consistency.
Ack
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42955 )
Change subject: mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42955 )
Change subject: mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42955 )
Change subject: mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp ......................................................................
mb/intel/tglrvp: Add EC_HOST_EVENT_USB_MUX for tglrvp
This change allows EC to change state of host-controlled USB MUX.
TEST=Built image and booted to kernel.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ia7c331157b1b4039e42c373f5b130a66f7594458 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42955 Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h b/src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h index f05cb77..52db2af 100644 --- a/src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h @@ -21,7 +21,8 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX))
#define MAINBOARD_EC_SMI_EVENTS \ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED))
-
Caveh Jalali (Code Review) -
John Zhao (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)