Attention is currently required from: Felix Held, Michał Żygowski.
Angel Pons has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/80318?usp=email )
Change subject: util/superiotool/ite: Add extra dumps for IT8613E EC
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80318/comment/ab3cb55e_c9d5c383?usp... :
PS6, Line 7: util/superiotool/ite: Add extra dumps for IT8613E EC
Where did you get the register information from? Datasheet? Would be nice to specify in the commit message.
https://review.coreboot.org/c/coreboot/+/80318/comment/8428d1c8_e85a3d49?usp... :
PS6, Line 14: briodge
typo: bridge
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80318?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Gerrit-Change-Number: 80318
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 10 Aug 2024 16:24:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes