Attention is currently required from: Mario Scheithauer, Lean Sheng Tan.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68214 )
Change subject: soc/intel/ehl: Fix incorrect access to MAC_MDIO_DATA register
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68214/comment/7b3f12bb_822a8f03
PS2, Line 9: Function 'setbits16' clears the data register first
setbits16 actually performs an 'OR' operation with the new data and the origin register entry. This now can lead to a reserved value in the register which can then lead to issues. So please just correct the commit and this CL is fine to go in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0212420be770e2ffdabebbfaf5dfbf8d99d25915
Gerrit-Change-Number: 68214
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 10 Oct 2022 09:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment