Attention is currently required from: Felix Singer, Wonkyu Kim, Benjamin Doron, Ravishankar Sarawadi, Stefan Reinauer, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ......................................................................
Patch Set 4:
(5 comments)
Patchset:
PS4:
weeeeell....... https://github. […]
Right, I may use OpenBoardPackage
File util/inteltool/gpio_names/tigerlake.h:
PS4:
I think the other headers were split off some C file in the past. […]
If the other files also lack the license, I would put a separate patch to fill all missing license headers
https://review.coreboot.org/c/coreboot/+/56171/comment/4a7c8983_2731d59d PS4, Line 361: };
you can add these as well - all with NF1: […]
These are GPD12+??
https://review.coreboot.org/c/coreboot/+/56171/comment/69481e4c_9dfd31c6 PS4, Line 901: tigerlake_pch_h_communities
tigerlake_pch_h_community_3 is missing.
Will check with other sources. This patch was entirely based on the Intel GPIO spreadhseet
File util/inteltool/pcr.c:
https://review.coreboot.org/c/coreboot/+/56171/comment/b9c05358_e49dcdb5 PS4, Line 108: case PCI_DEVICE_ID_INTEL_Q570: : case PCI_DEVICE_ID_INTEL_Z590: : case PCI_DEVICE_ID_INTEL_H570: : case PCI_DEVICE_ID_INTEL_B560: : case PCI_DEVICE_ID_INTEL_H510: : case PCI_DEVICE_ID_INTEL_WM590: : case PCI_DEVICE_ID_INTEL_QM580: : case PCI_DEVICE_ID_INTEL_HM570: : case PCI_DEVICE_ID_INTEL_C252: : case PCI_DEVICE_ID_INTEL_C256: : case PCI_DEVICE_ID_INTEL_W580:
I agree (found via testing). […]
Okay. We may pray that nobody changes the default sideband BAR...