Attention is currently required from: Felix Held, Julius Werner, Lean Sheng Tan, Matt DeVillier, Maximilian Brune.
Benjamin Doron has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/84796?usp=email )
Change subject: lib/{fit,fit_payload}.c: Enhance support for FIT images
......................................................................
Patch Set 5:
(1 comment)
File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/057728f0_d7f08b1c?usp... :
PS5, Line 105: load_secondaries
This doesn't even make an effort to check if a load address was requested. And as I comment on the x86 code, we may want to check if relocation is needed and then at least do *something*: either relocation, or print an error.
Generally, we should consume more of the image properties, perhaps config's `require-fit` too, and either handle them properly or print errors if the system is getting into an unexpected state.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84796?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a21954c0dc5fd820d135e8cd0599ce87903a1c0
Gerrit-Change-Number: 84796
Gerrit-PatchSet: 5
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 13 Dec 2024 19:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No