Attention is currently required from: Deepti Deshatty, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Li1 Feng, Nick Vaccaro, Paul Menzel, Rishika Raj, Subrata Banik, V Sowmya, Yuval Peress.
Varun Upadhyay has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83671?usp=email )
Change subject: mb/google/trulo: support ISH
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83671/comment/97f88271_c8c719f6?usp... :
PS2, Line 10: & Configure
and configure
Done
https://review.coreboot.org/c/coreboot/+/83671/comment/ebc308c5_674f05e0?usp... :
PS2, Line 9: Define ISH main firmware name so ISH shim loader can load firmware
: from file system & Configure GPIO for ISH
Please add a dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/83671/comment/ff5067bd_bceb0747?usp... :
PS2, Line 11:
What schematics version did you use?
Done
File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83671/comment/8be762d1_cd6492cf?usp... :
PS2, Line 50: trulo_ish
Let me check internally and come back.
Updated to a generic name ish_fw.bin
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83671?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id60cb416a1cce5407bd483f0ce54f477584459b1
Gerrit-Change-Number: 83671
Gerrit-PatchSet: 3
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Yuval Peress
peress@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Yuval Peress
peress@google.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Comment-Date: Thu, 01 Aug 2024 12:09:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Varun Upadhyay
varun.upadhyay@intel.com